Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue

From: Tomoya MORINAGA
Date: Thu Nov 25 2010 - 06:11:02 EST


On Wednesday, November 24, 2010 10:31 PM, Marc Kleine-Budde wrote :

>> For easy to read, some sub-functions are created.
>>
>>
>> Modify complex "goto" to do~while.
>What about the next_flag in the rx_normal function? Can you get rid of
>it, too?
Subsequent Patch (11/17 Delete unnecessary ...) deletes "next_flag" in the rx_normal function.

---
Thanks,

Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

----- Original Message -----
From: "Marc Kleine-Budde" <mkl@xxxxxxxxxxxxxx>
To: "Tomoya MORINAGA" <tomoya-linux@xxxxxxxxxxxxxxx>
Cc: "Wolfgang Grandegger" <wg@xxxxxxxxxxxxxx>; "Wolfram Sang" <w.sang@xxxxxxxxxxxxxx>; "Christian Pellegrin"
<chripell@xxxxxxxx>; "Barry Song" <21cnbao@xxxxxxxxx>; "Samuel Ortiz" <sameo@xxxxxxxxxxxxxxx>;
<socketcan-core@xxxxxxxxxxxxxxxx>; <netdev@xxxxxxxxxxxxxxx>; <linux-kernel@xxxxxxxxxxxxxxx>; "David S. Miller"
<davem@xxxxxxxxxxxxx>; <andrew.chih.howe.khor@xxxxxxxxx>; <qi.wang@xxxxxxxxx>; <margie.foster@xxxxxxxxx>;
<yong.y.wang@xxxxxxxxx>; <kok.howg.ewe@xxxxxxxxx>; <joel.clark@xxxxxxxxx>
Sent: Wednesday, November 24, 2010 10:31 PM
Subject: Re: [PATCH net-next-2.6 6/17 v3] can: EG20T PCH: Fix endianness issue


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/