Re: rcu_read_lock/unlock protect find_task_by_vpid call inmigrate_pages

[Dave Jones]

On Thu, Nov 25, 2010 at 09:50:37AM +0900, KOSAKI Motohiro wrote:
 
 > > @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
 > >  		goto out;
 > >  	}
 > >  	mm = get_task_mm(task);
 > > +	rcu_read_unlock();
 > >  	read_unlock(&tasklist_lock);
 > >  
 > >  	err = -EINVAL;
 > 
 > Thanks reporting. but mmotm seems already has the same patch.

indeed. It's also better than mine, which missed the unlock on error path.

thanks,

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/