Re: [PATCH] ARM: Fix find_next_zero_bit and related assembly

From: Stephen Boyd
Date: Wed Nov 24 2010 - 13:13:00 EST


On 11/23/2010 03:28 PM, James Jones wrote:
> On Tuesday 23 November 2010 13:26:47 Nicolas Pitre wrote:
>> On Thu, 11 Nov 2010, James Jones wrote:
>>> The find_next_bit, find_first_bit, find_next_zero_bit
>>> and find_first_zero_bit functions were not properly
>>> clamping to the maxbit argument at the bit level. They
>>> were instead only checking maxbit at the byte level.
>>> To fix this, add a compare and a conditional move
>>> instruction to the end of the common bit-within-the-
>>> byte code used by all the functions and be sure not to
>>> clobber the maxbit argument before it is used.
>>>
>>> Signed-off-by: James Jones <jajones@xxxxxxxxxx>
>>> Tested-by: Stephen Warren <swarren@xxxxxxxxxx>
>> Reviewed-by: Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>
>>
>> Please send to RMK's patch system.
> Thanks for the review. It's already in the patch system, but I updated the
> entry to include your reviewed-by line.

Should this be sent to the stable tree too?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/