Re: [PATCH] ASoC: nuc900-ac97: fix a memory leak

From: Wan ZongShun
Date: Wed Nov 24 2010 - 06:31:21 EST


2010/11/24 Liam Girdwood <lrg@xxxxxxxxxxxxxxx>:
> On Wed, 2010-11-24 at 16:44 +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
>> ---
>> Âsound/soc/nuc900/nuc900-ac97.c | Â Â2 +-
>> Â1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
>> index 293dc74..e00e39d 100644
>> --- a/sound/soc/nuc900/nuc900-ac97.c
>> +++ b/sound/soc/nuc900/nuc900-ac97.c
>> @@ -384,7 +384,6 @@ out0:
>>
>> Âstatic int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>> Â{
>> -
>> Â Â Â snd_soc_unregister_dai(&pdev->dev);
>>
>> Â Â Â clk_put(nuc900_ac97_data->clk);
>> @@ -392,6 +391,7 @@ static int __devexit nuc900_ac97_drvremove(struct platform_device *pdev)
>> Â Â Â release_mem_region(nuc900_ac97_data->res->start,
>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â resource_size(nuc900_ac97_data->res));
>>
>> + Â Â kfree(nuc900_ac97_data);
>> Â Â Â nuc900_ac97_data = NULL;
>>
>> Â Â Â return 0;
>
>
> Acked-by: Liam Girdwood <lrg@xxxxxxxxxxxxxxx>

Acked-by: Wan ZongShun <mcuos.com@xxxxxxxxx>

thanks!

> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
>



--
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@xxxxxxxxxxxxxxxx
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/