Re: [PATCH v4 0/6] FM V4L2 drivers for WL128x

[Pavan Savoy]

Hans, Mauro, Ohad,

On Wed, Nov 17, 2010 at 6:32 PM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote:
> Hi Manjunatha,
>
> On Tue, Nov 16, 2010 at 3:18 PM, Â<manjunatha_halli@xxxxxx> wrote:
>> Âdrivers/staging/ti-st/Kconfig    Â|  10 +
>> Âdrivers/staging/ti-st/Makefile    |  Â2 +
>> Âdrivers/staging/ti-st/fmdrv.h    Â| Â259 ++++
>> Âdrivers/staging/ti-st/fmdrv_common.c | 2141 ++++++++++++++++++++++++++++++++++
>> Âdrivers/staging/ti-st/fmdrv_common.h | Â458 ++++++++
>> Âdrivers/staging/ti-st/fmdrv_rx.c   | Â979 ++++++++++++++++
>> Âdrivers/staging/ti-st/fmdrv_rx.h   |  59 +
>> Âdrivers/staging/ti-st/fmdrv_tx.c   | Â461 ++++++++
>> Âdrivers/staging/ti-st/fmdrv_tx.h   |  37 +
>> Âdrivers/staging/ti-st/fmdrv_v4l2.c  | Â757 ++++++++++++
>> Âdrivers/staging/ti-st/fmdrv_v4l2.h  |  32 +
>> Â11 files changed, 5195 insertions(+), 0 deletions(-)
>
> Usually when a driver is added to staging, it should also have a TODO
> file specifying what needs to be done before the driver can be taken
> out of staging (at least as far as the author knows of today).
>
> It helps keeping track of the open issues in the driver, which is good
> for everyone - the author, the random contributor/observer, and
> probably even the staging maintainer.
>
> Can you please add such a TODO file ?
>
> Thanks,
> Ohad.

Thanks Ohad, for the comments, We do have an internal TODO.
In terms of functionality we have stuff like TX RDS which already has
few CIDs in the extended controls.
extend V4L2 for complete-scan, add in stop search during hw_seek .. etc...
But I just wanted to ask whether this is good enough to be staged.
Because as we begin to implement and add in the items in TODO - the
patch set will keep continuing to grow.

So Hans, Mauro, What do you think ?
It would be real helpful - if this can be staged, it is becoming
difficult to maintain for us.

Thanks,
Pavan

>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv.h
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_common.c
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_common.h
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_rx.c
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_rx.h
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_tx.c
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_tx.h
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_v4l2.c
>> Âcreate mode 100644 drivers/staging/ti-st/fmdrv_v4l2.h
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at Âhttp://www.tux.org/lkml/
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html
> Please read the FAQ at Âhttp://www.tux.org/lkml/
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/