Re: [RFC PATCH] Make swap accounting default behavior configurablev3

From: Michal Hocko
Date: Mon Nov 15 2010 - 03:35:50 EST


On Mon 15-11-10 10:13:35, Daisuke Nishimura wrote:
> On Fri, 12 Nov 2010 09:31:03 +0100
[...]
> > diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
> > index ed45e98..7077148 100644
> > --- a/Documentation/kernel-parameters.txt
> > +++ b/Documentation/kernel-parameters.txt
> > @@ -1752,6 +1752,8 @@ and is between 256 and 4096 characters. It is defined in the file
> >
> > noswapaccount [KNL] Disable accounting of swap in memory resource
> > controller. (See Documentation/cgroups/memory.txt)
> > + swapaccount [KNL] Enable accounting of swap in memory resource
> > + controller. (See Documentation/cgroups/memory.txt)
> >
> > nosync [HW,M68K] Disables sync negotiation for all devices.
> >
> (I've add Andrew and Balbir to CC-list.)
> It seems that almost all parameters are listed in alphabetic order in the document,
> so I think it would be better to obey the rule.

You are right. The header of the file says:

" The following is a consolidated list of the kernel parameters as
implemented (mostly) by the __setup() macro and sorted into English
Dictionary order (defined as ignoring all punctuation and sorting digits
before letters in a case insensitive manner), and with descriptions
where known."

Updated patch follows bellow.

>
> Thanks,
> Daisuke Nishimura.

Changes since v2:
* put the new parameter description to the proper (alphabetically sorted)
place in Documentation/kernel-parameters.txt

Changes since v1:
* do not remove noswapaccount parameter and add swapaccount parameter instead
* Documentation/kernel-parameters.txt updated
---