Re: [PATCH UPDATED 1/5] mtd: fix bdev exclusive open bugs inblock2mtd::add_device()

From: Artem Bityutskiy
Date: Sat Nov 13 2010 - 06:14:49 EST


On Sat, 2010-11-13 at 11:59 +0100, Tejun Heo wrote:
> There are two bdev exclusive open bugs.
>
> * open_bdev_exclusive() must not be called with NULL holder. Use dev
> as the holder.
>
> * open_by_devnum() doesn't open the bdev exclusively but
> block2mtd_free_device() always assumes it. Explicitly claim the
> bdev.
>
> The latter is rather clumsy but will be simplified with future
> blkdev_get/put() cleanups.
>
> - Updated to use local variable @mode to cache FMODE_* masks as
> suggested by Artem Bityutskiy.

Do you want this patch to go in via Jens' tree with the rest of the
series, or as an independent patch via the mtd tree?

Anyway,

Acked-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>

Thanks!

--
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/