Re: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates

From: Andrei Emeltchenko
Date: Fri Nov 12 2010 - 08:20:16 EST


On Fri, Nov 12, 2010 at 3:17 PM, G, Manjunath Kondaiah <manjugk@xxxxxx> wrote:
>
>
>> -----Original Message-----
>> From: linux-omap-owner@xxxxxxxxxxxxxxx
>> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of
>> Emeltchenko Andrei
>> Sent: Friday, November 12, 2010 6:34 PM
>> To: linux-omap@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> linux-arm@xxxxxxxxxxxxxxxxxxxxxx; linux-serial@xxxxxxxxxxxxxxx
>> Subject: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates
>
> s/diplicates/duplicates
>
>>
>> From: Andrei Emeltchenko <andrei.emeltchenko@xxxxxxxxx>
>>
>> Add MDR1 Serial register definition to serial_reg and remove
>> duplicated
>> code, remove magic MDR1 register numbers from serial drivers.
>>
>> *v2 add OMAP keyword to MDR1 definition
>> *v3 remove magic from serial drivers
>> *v4 taking comments from Manjunath and Govindraj: typos, CC
>>
>> Andrei Emeltchenko (4):
>>   OMAP: Serial: Define OMAP uart MDR1 register definitions
>>   OMAP1: Serial: remove magic numbers for MDR1 reg
>>   OMAP2: Serial: remove magic numbers for MDR1 reg
>>   OMAP: Serial: remove redefined MDR1 register definitions
>>
>>  arch/arm/mach-omap1/serial.c                  |    6 ++++--
>>  arch/arm/mach-omap2/serial.c                  |   15 +++++++++------
>>  arch/arm/plat-omap/include/plat/omap-serial.h |    3 ---
>>  drivers/serial/omap-serial.c                  |    6 +++---
>>  include/linux/serial_reg.h                    |   12 ++++++++++++
>>  5 files changed, 28 insertions(+), 14 deletions(-)
>
> Do you think patch series is required for these changes? How about
> merging with single patch?

I can merge, sometimes somebody need patches to be split, merging is easy.

-- Andrei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/