RE: [PATCH] input: Add sysfs interface to on/off state of GPIO keysand switches

From: Lighthart, EricX
Date: Thu Nov 11 2010 - 09:24:30 EST


There's the already-existing solution I was looking for.
Thanks Mark.

Dmitry, et al, please withdraw the patch.

> -----Original Message-----
> From: Mark Brown [mailto:broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx]
> Sent: Thursday, November 11, 2010 6:16 AM
> To: Lighthart, EricX
> Cc: dmitry.torokhov@xxxxxxxxx; pb@xxxxxxxxxxxxx; ext-
> mika.1.westerberg@xxxxxxxxx; linux-input@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] input: Add sysfs interface to on/off state of GPIO
> keys and switches
>
> On Thu, Nov 11, 2010 at 06:03:35AM -0800, Lighthart, EricX wrote:
> > User space cannot learn the current state of a GPIO key or switch.
> > Input system reports only changes, not state.
> >
> > Add two sysfs attributes, one each for keys and switches, that
> > report lists of keys or switches currently "on."
>
> There's EVIOCG* ioctl()s for this. Something sysfs (or a widely
> distributed utility) would be very helpful but there is actually a
> facility to read the state.
>
> > drivers/input/keyboard/gpio_keys.c | 68
> ++++++++++++++++++++++++++++--------
>
> If something is needed here it should be done as part of the input
> layer, not in a driver specific fashion - there's nothing specific to
> GPIO keys here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/