RE: [PATCH v2] POWER: Add gpio charger driver

From: Rhyland Klein
Date: Wed Nov 10 2010 - 19:56:28 EST


> From: Anton Vorontsov [mailto:cbouatmailru@xxxxxxxxx]
> Sent: Thursday, November 04, 2010 10:48 AM
> To: Rhyland Klein
> Cc: Lars-Peter Clausen; broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx; Andrew Chew;
> olof@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2] POWER: Add gpio charger driver
>
> On Thu, Oct 28, 2010 at 02:17:41PM -0700, Rhyland Klein wrote:
> [...]
> > > Hm... I guess it can be, but on the other hand most platform bus
> chargers
> > > type
> > > devices can be, because the pda_power driver is keep pretty generic
> with
> > > custom init,
> > > status and exit callbacks.
> > >
> > > - Lars
> >
> > I didn't see any more discussion on this. Is the plan to integrate
> > the gpio-charger driver as is or to instead try to integrate support
> > for this into pda_power?
>
> Sorry for the delayed response, and thanks for the pings! ;-)
>
> The main thing I'm afraid of is duplication. I.e. someday you
> will want debouncing (include/linux/pda_power.h's wait_for_status,
> wait_for_charger parameters) support, regulators support etc.
>
> And your gpio driver will look very similar to pda_power.
>
> So I'd vote for adding the GPIO functionality to pda_power, and
> refactoring it if needed.
>
> Though, if there are strong objections against this idea, I
> can merge the GPIO driver, and let's see how things will evolve.
>
> Thanks!
>
> --
> Anton Vorontsov
> email: cbouatmailru@xxxxxxxxx
> irc://irc.freenode.net/bd2

My guess, is that since no one has responded, no one is working on integrating the functionality into pda-power?

-rhyland
N‹§²æìr¸›yúèšØb²X¬¶ÇvØ^–)Þ{.nÇ+‰·¥Š{±‘êçzX§¶›¡Ü}©ž²ÆzÚ&j:+v‰¨¾«‘êçzZ+€Ê+zf£¢·hšˆ§~†­†Ûiÿûàz¹®w¥¢¸?™¨è­Ú&¢)ßf”ù^jÇy§m…á@A«a¶Úÿ 0¶ìh®å’i