Re: [GPIO]implement sleeping GPIO chip removal

From: Thomas Gleixner
Date: Wed Nov 10 2010 - 17:48:11 EST


On Wed, 10 Nov 2010, Greg KH wrote:
> On Wed, Nov 10, 2010 at 02:15:40PM -0700, Grant Likely wrote:
> > On Wed, Nov 10, 2010 at 10:07:05PM +0100, Thomas Gleixner wrote:
> > > If we see a shortcoming like this, we fix it and do not magically work
> > > around it.
> >
> > +1
> >
> > Thomas is right. kobject reference counting is the correct solution.
> > Nack on this approach.
>
> Only use a kobject if you want to be in the sysfs hierarchy (which I
> don't think you want to do here.) If you want proper reference
> counting, use a 'struct kref' instead.

Oops, yes. I always confuse those.

Thanks for pointing it out - probably not the first time :)

tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/