Re: [PATCH] cifs: fix another memleak, in cifs_root_iget

From: Jesper Juhl
Date: Wed Nov 10 2010 - 17:11:18 EST


On Wed, 10 Nov 2010, Oskar Schirmer wrote:

> cifs_root_iget allocates full_path through
> cifs_build_path_to_root, but fails to kfree it upon
> cifs_get_inode_info* failure.
>
> Make all failure exit paths traverse clean up
> handling at the end of the function.
>
> Signed-off-by: Oskar Schirmer <oskar@xxxxxxxxx>
> Cc: stable@xxxxxxxxxx

I've reviewed your patch (although not actually tested it) and your
changes look sane.
So, feel free to add

Reviewed-by: Jesper Juhl <jj@xxxxxxxxxxxxx>


--
Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/