Re: [RFC][PATCH 05/22] sched: SCHED_DEADLINE policy implementation

From: Peter Zijlstra
Date: Wed Nov 10 2010 - 15:21:37 EST


On Fri, 2010-10-29 at 08:30 +0200, Raistlin wrote:
> +static void update_dl_entity(struct sched_dl_entity *dl_se)
> +{
> + struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
> + struct rq *rq = rq_of_dl_rq(dl_rq);
> +
> + /*
> + * The arrival of a new instance needs special treatment, i.e.,
> + * the actual scheduling parameters have to be "renewed".
> + */
> + if (dl_se->dl_new) {
> + setup_new_dl_entity(dl_se);
> + return;
> + }
> +
> + if (dl_time_before(dl_se->deadline, rq->clock) ||
> + dl_entity_overflow(dl_se, rq->clock)) {
> + dl_se->deadline = rq->clock + dl_se->dl_deadline;
> + dl_se->runtime = dl_se->dl_runtime;
> + }
> +}

Can't we loose runtime deficit this way?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/