Re: [PATCH -tip] microcode, AMD: Cleanup code a bit

From: Ingo Molnar
Date: Wed Nov 10 2010 - 08:23:06 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> On Wed, Nov 10, 2010 at 03:31:21AM -0500, Ingo Molnar wrote:
> > Hm, what tree is this against - it doesnt apply here:
>
> Ah, there's this one other patch that goes before that, sorry for not
> mentioning it to you - I guess you still cannot read minds :-)
>
> http://marc.info/?l=linux-kernel&m=128864852428104
>
> Anyway, I've applied the two ontop of tip/x86/microcode and uploaded
> them to
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git tip-microcode

Ok, good. Please fix commit 35dc0ff46f77 if you want me to pull it, you should be in
the signoff chain as a submaintainer who pushes bits, i.e. your entry should be:

Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>

not:

Acked-by: Borislav Petkov <borislav.petkov@xxxxxxx>

Also, while touching up details, please remove the colon after the sentence:

35dc0ff46f77: microcode, AMD: Prefer vzalloc() over calls to vmalloc()+memset().

All arch/x86 commit titles are open-ended sentences that start with a verb.

Also, please use a 'x86, microcode, AMD: ' prefix.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/