Re: [PATCH -tip] microcode, AMD: Cleanup code a bit

From: Ingo Molnar
Date: Wed Nov 10 2010 - 03:31:34 EST



* Borislav Petkov <bp@xxxxxxxxx> wrote:

> get_ucode_data is a memcpy() wrapper which always returns 0. Move it
> into the header and make it an inline. Remove all code checking its
> return value and turn it into a void.
>
> There should be no functionality change resulting from this patch.
>
> Signed-off-by: Borislav Petkov <borislav.petkov@xxxxxxx>
> ---
> arch/x86/include/asm/microcode.h | 6 ++++++
> arch/x86/kernel/microcode_amd.c | 25 +++++--------------------
> 2 files changed, 11 insertions(+), 20 deletions(-)

Hm, what tree is this against - it doesnt apply here:

Hunk #3 FAILED at 180.
Hunk #4 succeeded at 195 (offset -1 lines).
Hunk #5 succeeded at 211 (offset -1 lines).
1 out of 5 hunks FAILED -- rejects in file arch/x86/kernel/microcode_amd.c

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/