Re: [PATCH 1/9] drivers/gpu/drm/drm_stub.c: Use printf extension%pV

From: Joe Perches
Date: Tue Nov 09 2010 - 21:31:16 EST


On Tue, 2010-11-09 at 21:16 -0500, Kristian HÃgsberg wrote:
> On Tue, Nov 9, 2010 at 7:35 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > Using %pV reduces the number of printk calls and
> > eliminates any possible message interleaving from
> > other printk calls.

> Wouldn't it be easier and more convenient to just make the %pV format
> specifier just expect a format string and the va_arg list? Like this
> printk(KERN_DEBUG "%pV", format, &args);
> I mean, the %pV is kernel specific and we can just change how it works.

No it wouldn't.

gcc would now warn about a mismatch between format and arguments.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/