Re: [PATCH] fanotify: Do check against max_marks and increasenumber of group marks atomically

From: Eric Paris
Date: Tue Nov 09 2010 - 15:21:57 EST


On Tue, 2010-11-09 at 19:19 +0100, Lino Sanfilippo wrote:
> The number of group marks is checked against max_marks and increased afterwards
> in a non atomic way. This may result in 2 or more processes passing the check
> at the same time and increasing the number of group marks above the max_marks
> limit afterwards.
> With this patch the check against max_marks is done in fsnotify_add_mark(),
> after the group lock has been aquired to ensure that concurrent processes
> cant exceed the group marks limit.
>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@xxxxxx>

applied to http://git.infradead.org/users/eparis/notify.git/ #for-next

-Eric

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/