Re: [PATCH V2] include/linux/kernel.h: Move logging bits toinclude/linux/logging.h

From: Alexey Dobriyan
Date: Tue Nov 09 2010 - 15:01:34 EST


On Tue, Nov 09, 2010 at 10:49:19AM -0800, Linus Torvalds wrote:
> On Tue, Nov 9, 2010 at 10:43 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> >
> > diff from V1 - Don't add pr_<level>_once macros
> >
> >  include/linux/kernel.h  |  244 +--------------------------------------
> >  include/linux/logging.h |  295 +++++++++++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 296 insertions(+), 243 deletions(-)
> >  create mode 100644 include/linux/logging.h
>
> So where do the extra 53 lines come from now?
>
> This still is clearly not just code movement, and it's impossible for
> me to see what actually changed. Something must have.

Why linux_banner is moved?
Why linux_proc_banner is moved?
Why header is not named printk.h?
Why random stuff like log_buf_kexec_setup() and hexdump is moved?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/