Re: [PATCH 61 of 66] use compaction for GFP_ATOMIC order > 0

From: KOSAKI Motohiro
Date: Tue Nov 09 2010 - 05:27:47 EST


> From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>
> This takes advantage of memory compaction to properly generate pages of order >
> 0 if regular page reclaim fails and priority level becomes more severe and we
> don't reach the proper watermarks.
>
> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>

First, I don't think this patch is related to GFP_ATOMIC. So, I think the
patch title is a bit misleading.

Second, this patch has two changes. 1) remove PAGE_ALLOC_COSTLY_ORDER
threshold 2) implement background compaction. please separate them.

Third, This patch makes a lot of PFN order page scan and churn LRU
aggressively. I'm not sure this aggressive lru shuffling is safe and
works effective. I hope you provide some demonstration and/or show
benchmark result.

Thanks.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/