Re: [PATCH 6/6 v2] ARM: Add support for the display controllers inVT8500 and WM8505

[Alexey Charkov]

2010/11/8 Arnd Bergmann <arnd@xxxxxxxx>:
> On Sunday 07 November 2010, Alexey Charkov wrote:
>> Âdrivers/video/Kconfig     |  26 +++
>> Âdrivers/video/Makefile    Â|  Â3 +
>> Âdrivers/video/vt8500lcdfb.c  | Â452 +++++++++++++++++++++++++++++++++++++++++
>> Âdrivers/video/vt8500lcdfb.h  |  34 +++
>> Âdrivers/video/wm8505fb.c   Â| Â438 +++++++++++++++++++++++++++++++++++++++
>> Âdrivers/video/wm8505fb_regs.h | Â 76 +++++++
>> Âdrivers/video/wmt_ge_rops.c  | Â186 +++++++++++++++++
>> Âdrivers/video/wmt_ge_rops.h  |  Â5 +
>
> From a very brief look, the two drivers look rather similar. What is the
> reason to have separate drivers instead of just one?
>
> Could you perhaps take the common parts and move them into a third module
> that exports symbols to be used by the two drivers?
>

Quite frankly, I would say that all SoC framebuffer drivers are quite
similar ;-) Register offsets, timing formats, accepted pixel formats,
buffer alignment requirements are all different, so I do not really
believe that there'd be much benefit from introducing another
abstraction level. This is open to debate, of course.

Alexey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/