Re: [Resend][PATCH 2/2] Drivers: block: aoe: Makefile: replace theuse of <module>-objs with <module>-y

From: Andrew Morton
Date: Mon Nov 08 2010 - 16:06:27 EST


On Mon, 8 Nov 2010 10:03:24 -0500
Ed Cashin <ecashin@xxxxxxxxxx> wrote:

> On Nov 6, 2010, at 2:58 PM, Tracey Dent wrote:
>
> > Changed <module>-objs to <module>-y in Makefile.
>
> Andrew Morton, hi. I don't know whether Tracey Dent is expecting
> me to push this change to Linus, but lately you've been pushing the
> aoe changes. I see similar changes in other
> drivers on the LKML, so if it looks good to you, would you mind please
> picking up this patch?

I queued both patches - I guess I'll send them to Jens.

I queued them as "unchangelogged patches". Because what the changelogs told
us was utterly obvious from reading the patch.

What the changelogs didn't tell us was _why_ the change was made. And
guess what? I don't have a clue! I just haven't been following these
kbuild minutea.

Tracey, please send a description of *why* this change is being made
and I'll add it to the changelogs. Please include that explanation in
all such patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/