Re: [PATCH] x86: fix apic.h unused but set warnings

[Andi Kleen]

>  At least the former code _didn't_ hide the details of which
> part of 'long long' value we need. Would not
> 
>  u64 val;
>  rdmsrl(APIC_BASE_MSR + (reg >> 4), val);
>  return (u32)val;
> 
> be more clear?

Maybe, but I doubt it will make much difference either way.

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/