Re: [PATCH 02/16 v2] pramfs: super block operations

From: Marco Stornelli
Date: Sat Nov 06 2010 - 11:03:10 EST


Il 06/11/2010 12:16, James Hogan ha scritto:
> Hi Marco,
>
> On Sat, Nov 06, 2010 at 09:56:39AM +0100, Marco Stornelli wrote:
>> From: Marco Stornelli <marco.stornelli@xxxxxxxxx>
>> +static void pram_set_blocksize(struct super_block *sb, unsigned long size)
>> +{
>> + int bits;
>> +
>> + /*
>> + * We've already validated the user input and the value here must be
>> + * between PRAM_MAX_BLOCK_SIZE and PRAM_MIN_BLOCK_SIZE
>> + * and it must be a power of 2.
>> + */
>
> Should this comment have spaces after the tabs to be consistent with the
> other multiline comments (pram_ioremap) and the coding style?
>

Ok, no problem.

Thanks for the review.

Regards,

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/