Re: [PATCH] leds-net5501: taints kernel, add license

From: Richard Purdie
Date: Fri Nov 05 2010 - 09:53:52 EST


On Thu, 2010-11-04 at 10:28 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> Add MODULE_LICENSE() that matches file comments so that kernel
> is not tainted.
>
> leds_net5501: module license 'unspecified' taints kernel.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Acked-by: Richard Purdie <rpurdie@xxxxxxxxxxxxxxx>

> ---
> drivers/leds/leds-net5501.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Alessandro, why does this module not have a module_exit() function?
> I.e., why can it not be unloaded?
>
>
> --- lnx-2637-rc1.orig/drivers/leds/leds-net5501.c
> +++ lnx-2637-rc1/drivers/leds/leds-net5501.c
> @@ -92,3 +92,5 @@ unmap:
> }
>
> arch_initcall(soekris_init);
> +
> +MODULE_LICENSE("GPL");
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/