Re: [PATCH 2/3] regulator: Ensure enough delay time for enablingregulator

[Mark Brown]

On Fri, Nov 05, 2010 at 03:26:20PM +0800, Axel Lin wrote:

> -			if (delay >= 1000)
> +			if (delay >= 1000) {
>  				mdelay(delay / 1000);
> -			else if (delay)
> +				udelay(delay % 1000);
> +			} else if (delay)
>  				udelay(delay);

This looks good but please change this to use { } in the else case also;
I find this very helpful for legibility.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/