Re: [PATCH 1/9] Add yaffs Kconfig and Makefile

[Greg KH]

On Fri, Nov 05, 2010 at 09:58:38AM +1300, Charles Manning wrote:
> On Thursday 04 November 2010 06:46:07 Greg KH wrote:
> > On Thu, Nov 04, 2010 at 05:53:16AM +1300, cdhmanning@xxxxxxxxx wrote:
> > > From: Charles Manning <cdhmanning@xxxxxxxxx>
> > >
> > > Adding yaffs2 file system.
> > >
> > > Signed-off-by: Charles Manning <cdhmanning@xxxxxxxxx>
> > > ---
> > >  fs/yaffs2/Kconfig  |  190
> > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ fs/yaffs2/Makefile |
> > >   17 +++++
> >
> > Don't do this as your first patch, make it your last one.  Otherwise the
> > build will break when you apply this one to the tree.
> > Remember, we need to be able to have a correct build at every patch in
> > the whole development series, otherwise tools like 'git bisect' will not
> > work properly.
> 
> I left the actual hook in to the tree building to the last patch which changes 
> fs/Kconfig and fs/Makefile.  Thus building the whole of Linux would not 
> break.
> 
> I suppose the best is to put all the Kconfigs and Makefile changes in the last 
> patch.

Either way, you are correct, this works as-is, it was my mistake in
reviewing it, sorry for the noise.

> > Also, is your goal to get this cleaned up good enough to get it into .38
> > in the "real" place in the kernel, or do you want to see it go through
> > staging and take a bit longer to get everything cleaned up properly
> > before moving to the "real" location?
> 
> My goal it to get this into mainline, .38 preferred.
> 
> I am a complete newbie when it comes to this process. What's the best
> path to getting there? 

I don't know, both will work.

> My preference is to keep cleaning up code in yaffs.net and patching
> from there as this will keep the trees closer together and minimise
> clerical issues.

Sure, but remember, once the code goes into mainline, having an external
tree is a huge liability, not a benifit at all, so consider dropping it.

Until then, if you want to go for .38 in the "real" part of the tree,
take the review comments people made, and then respin the patches and
resend them asking for comments.  I think Andrew Morton usually merges
new filesystems, so after everyone on linux-fs is "happy" with the
patches, ask him to take them for merging into .38.

Good luck,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/