Re: panic with 2.6.37-rc1

[Tom Gundersen]

On Wed, Nov 3, 2010 at 11:11 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le mercredi 03 novembre 2010 Ã 23:02 +0100, Tom Gundersen a Ãcrit :
>> I get panic during boot both with 2.6.37-rc1 and with current head.
>>
>> Here is the error message:
>> <http://www.lix.polytechnique.fr/~tom/2.6.37-rc1-panic.jpg>. My
>> .config is below.
>>
>> Let me know if you want more info. If you want I can test patches or
>> bisect (if no one has any better suggestions).
>>
>
> Please test following patch, thanks
>
> [PATCH] atl1 : fix panic on load
>
> Its now illegal to call netif_stop_queue() before register_netdev()
>
> Reported-by: Tom Gundersen <teg@xxxxxxx>
> Signed-off-by: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> ---
> Âdrivers/net/atlx/atl1.c | Â Â1 -
> Â1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/atlx/atl1.c b/drivers/net/atlx/atl1.c
> index 43579b3..5336310 100644
> --- a/drivers/net/atlx/atl1.c
> +++ b/drivers/net/atlx/atl1.c
> @@ -3043,7 +3043,6 @@ static int __devinit atl1_probe(struct pci_dev *pdev,
> Â Â Â Âatl1_pcie_patch(adapter);
> Â Â Â Â/* assume we have no link for now */
> Â Â Â Ânetif_carrier_off(netdev);
> - Â Â Â netif_stop_queue(netdev);
>
> Â Â Â Âsetup_timer(&adapter->phy_config_timer, atl1_phy_config,
> Â Â Â Â Â Â Â Â Â Â(unsigned long)adapter);
>
>

The patch solves the problem. Thanks!

Tom
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/