Re: [PATCH 1/9] Add yaffs Kconfig and Makefile

From: Greg KH
Date: Wed Nov 03 2010 - 13:49:26 EST


On Thu, Nov 04, 2010 at 05:53:16AM +1300, cdhmanning@xxxxxxxxx wrote:
> From: Charles Manning <cdhmanning@xxxxxxxxx>
>
> Adding yaffs2 file system.
>
> Signed-off-by: Charles Manning <cdhmanning@xxxxxxxxx>
> ---
> fs/yaffs2/Kconfig | 190 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> fs/yaffs2/Makefile | 17 +++++

Don't do this as your first patch, make it your last one. Otherwise the
build will break when you apply this one to the tree.

Remember, we need to be able to have a correct build at every patch in
the whole development series, otherwise tools like 'git bisect' will not
work properly.

Also, is your goal to get this cleaned up good enough to get it into .38
in the "real" place in the kernel, or do you want to see it go through
staging and take a bit longer to get everything cleaned up properly
before moving to the "real" location?

Either is fine with me, just curious.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/