Re: Resend [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

From: Jiri Kosina
Date: Wed Nov 03 2010 - 10:44:34 EST


On Wed, 3 Nov 2010, gimli wrote:

>
> On Wed, 3 Nov 2010 09:56:21 -0400 (EDT), Jiri Kosina <jkosina@xxxxxxx>
> wrote:
> > On Wed, 3 Nov 2010, gimli wrote:
> >
> >> Does this look better ?
> >
> > What I would actually prefer would be something like
> >
> >
> > if ( ... )
> > table = macbookair_fn_keys;
> > else if ( ... )
> > table = powerbook_fn_keys;
> > else
> > table = apple_fn_keys;
> >
> > apple_find_translation(table, usage->code);
> >
> >> I also use the USB id's for the if.
> Next try.

I have slightly modified the code to be more like what I proposed above,
and applied the patch. Thanks a lot,

--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/