Re: Resend [PATCH 3/4] MacbookAir3,1 and 3,2 hid support

[Jiri Kosina]

On Tue, 26 Oct 2010, gimli wrote:

> This patch adds support for the new MacBookAir3,1 and 3,2 to the hid
> driver.
> 
> Updated names names acording Apples kext.
> 
> Signed-off-by: Edgar (gimli) Hucek <gimli@xxxxxxxxxxxxxx>

> -               trans = apple_find_translation((hid->product < 0x21d ||
> +               if(hid->product >= 0x023f && hid->product <= 0x0244 ) {
> +                       trans = apple_find_translation(macbookair_fn_keys, usage->code);
> +               } else {
> +                       trans = apple_find_translation((hid->product < 0x21d ||
>                                        hid->product >= 0x300) ?
>                                        powerbook_fn_keys : apple_fn_keys,
>                                        usage->code);

Could you please make this nicer? Having if and ternary operator both 
there to chose the translation table looks really confusing.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/