Re: [Device-drivers-devel] [PATCH] video: backlight: adp8870: Fixwarn_unused_result warning reported by Stephen Rothwell

[Mike Frysinger]

On Fri, Oct 29, 2010 at 15:25, Andrew Morton wrote:
>> Subject: [PATCH] video: backlight: adp8870: Fix warn_unused_result warning reported by Stephen Rothwell
>
> Lots of people are doing this "video: backlight: adp8870:" thing
> lately. ÂAnd it's good, but why not just use
> "drivers/video/backlight/adp8860_bl.c" to identify the affected
> susbsytem/file/etc? ÂIt's simple and uniform. ÂIt's not always the
> appropriate thing to do, but replacing the /'s with ": " seems rather
> random and pointless.

the colons and spaces make it a lot easier to pick out in a git log.
your suggestion makes it much harder to read due to the lack of
whitespace.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/