Re: [2.6.37-rc1, patch] r8169: fix sleeping while holding spinlock...

[Francois Romieu]

Daniel J Blueman <daniel.blueman@xxxxxxxxx> :
> Recent changes to the r8169 driver cause it to call
> device_set_wakeup_enable under spinlock, which may sleep.

The change is fine but the description is misleading : the r8169
driver has been issuing device_set_wakeup_enable under spinlock since
october 2008. device_set_wakeup_enable did not sleep until recently
(see f2dc0d1809ab7e0147c7e4ac837be1682f706538 for instance).

drivers/net/gianfar_ethtool.c::gfar_set_wol is broken as well when
CONFIG_PM is set.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/