Re: [PATCH] cgroup: prefer [kv]zalloc over [kv]malloc+memset inmemory controller code.

[Johannes Weiner]

On Mon, Nov 01, 2010 at 08:40:56PM +0100, Jesper Juhl wrote:
> Hi (please CC me on replies),
> 
> 
> Apologies to those who receive this multiple times. I screwed up the To: 
> field in my original mail :-(
> 
> 
> In mem_cgroup_alloc() we currently do either kmalloc() or vmalloc() then 
> followed by memset() to zero the memory. This can be more efficiently 
> achieved by using kzalloc() and vzalloc().
> 
> 
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>

Looks good to me, but there is also the memset after kmalloc in
alloc_mem_cgroup_per_zone_info().  Can you switch that over as well in
this patch?  You can pass __GFP_ZERO to kmalloc_node() for zeroing.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/