Re: [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable"

[KOSAKI Motohiro]

> On Tue, 26 Oct 2010, KOSAKI Motohiro wrote:
> 
> > > NACK as a logical follow-up to my NACK for "oom: remove totalpage 
> > > normalization from oom_badness()"
> > 
> > Huh?
> > 
> > I requested you show us justification. BUT YOU DIDNT. If you have any 
> > usecase, show us RIGHT NOW. 
> > 
> 
> The new tunable added in 2.6.36, /proc/pid/oom_score_adj, is necessary for 
> the units that the badness score now uses.  We need a tunable with a much 

Who we?

> higher resolution than the oom_adj scale from -16 to +15, and one that 
> scales linearly as opposed to exponentially.  Since that tunable is much 
> more powerful than the oom_adj implementation, which never made any real 

The reason that you ware NAKed was not to introduce new powerful feature.
It was caused to break old and used feature from applications.


> sense for defining oom killing priority for any purpose other than 
> polarization, the old tunable is deprecated for two years.

You haven't tested your patch at all. Distro's initram script are using
oom_adj interface and latest kernel show pointless warnings 
"/proc/xx/oom_adj is deprecated, please use /proc/xx/oom_score_adj instead."
at _every_ boot time.

As I said, DON'T SEND UNTESTED PATCH! DON'T BREAK USERLAND CARELESSLY!


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/