Re: [PATCH 2/2] jump label: disable due to compiler bug

From: Richard Henderson
Date: Fri Oct 29 2010 - 14:14:39 EST


On 10/29/2010 10:48 AM, David Daney wrote:
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226
>
> Perhaps it could be integrated with the current checks for the presence of 'asm goto'

If you're looking for a cross-compile-able test, you can strip the
testcase down to

extern void abort(void);
void g(int x, ...);
void f(int x)
{
if (x == 0)
g(0);
g(1, 2, 3, 4, 5, 6, 7);
asm goto ("XYZZY" : : : : label);
abort ();
label:
return;
}

and use perl to notice the adjustment to esp before or after XYZZY.
It should be fairly obvious looking at the assembly before and after
the patch.

I don't know what sort of embedded processors supported by linux
actually use ACCUMULATE_OUTGOING_ARGS. Almost all ports don't, so
I'd be pretty comfortable making this a 32-bit x86 only test, and
let other targets just check that the test compiles.


r~
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/