Re: [PATCH 2/2] jump label: disable due to compiler bug

From: David Daney
Date: Fri Oct 29 2010 - 13:48:39 EST


On 10/29/2010 10:33 AM, Steven Rostedt wrote:
On Fri, 2010-10-29 at 10:18 -0700, David Daney wrote:

I hate to continue beating a dead horse, but RTH just committed the GCC
patch, and it will be part of GCC-4.5.2 and later.

Great!


Should this knowledge be builtin to the jump label enabling calculus?

No, because we can't trust versions. We never know what home grown gcc a
kernel developer is using (and what has been backported or not). Thus
the only option is to have a builtin test we can do at compile time to
determine if the bug exists or not and decide then.


The test case is in the GCC bug report, and is quite small:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46226

Perhaps it could be integrated with the current checks for the presence of 'asm goto'

Note, I'm currently running my last set of patches through ktest. When
it finishes (presumably with no issues), I'll post a pull request.

-- Steve



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/