Re: [PATCH 2/2] jump label: disable due to compiler bug

[Steven Rostedt]

On Fri, 2010-10-29 at 08:34 +0200, Ingo Molnar wrote:
> * Jason Baron <jbaron@xxxxxxxxxx> wrote:
> 
> > Thus, I'm going to propose a patch, which makes jump label conditional on x86_64 
> > for now [...]
> 
> No, we dont do 64-bit only features really.
> 
> > [...] (adding -maccumulate-outgoing-args to x86 increases the text size, so I'm 
> > not proposing adding the flag there).
> 
> Please make jump labels configurable instead. (dependent on EMBEDDED)

Do you mean to have it dependent on !EMBEDDED, or perhaps 
!CC_OPTIMIZE_FOR_SIZE ?

I can see people making a big stink about adding back a gcc option that
makes the kernel bigger.

-- Steve

> 
> Also, could you please send the fix to me ASAP? We dont need confirmation and 
> re-confirmation and testing, as this thing is crashing on me several times every 
> single day ...
> 
> I also know that 64-bit never crashed this way, nor did the 32-bit kernel with 
> function tracer enabled - so -maccumulate-outgoing-args will likely fix it.
> 
> Lets get the ball rolling so we can get it to Linus today ...



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/