Re: [PATCH 2/7] cgroups: Allow to bind a subsystem to a cgroup hierarchy

[Paul Menage]

On Fri, Oct 22, 2010 at 1:09 AM, Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> +       /*
> +        * Indicate if this subsystem can be bound/unbound to/from a cgroup
> +        * hierarchy which has child cgroups.
> +        */
> +       unsigned int can_bind:1;

Maybe call this "bindable"?

Basic idea looks great, it could do with a bunch more comments, and
maybe locking rules.

Is there any chance of a lock inversion between dir->i_mutex and
cgroup_lock in hierarchy_popuiate_dir() ?

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/