Re: How do I add yaffs file system to mainline?

[Randy Dunlap]

On 10/28/10 11:29, Joe Perches wrote:
> On Thu, 2010-10-28 at 11:08 -0700, Greg KH wrote:
>> On Fri, Oct 29, 2010 at 06:55:39AM +1300, Charles Manning wrote:
>>> I know there is a style guide etc, but when we're talking about processing 15k 
>>> loc then some of those rules might be slightly bendable.
>>
>> Not really.
>>
>> Have you run it through sparse and scripts/checkpatch.pl?  If not,
>> please do so and resolve all of the issues that they bring up.
> 
> I wouldn't do that.  Checkpatch is useful but frequently wrong.
> By all means do use checkpatch, but please use your own taste to
> determine what you think needs fixing.


Absolutely.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/