Re: [next-20101038] Call trace in ext4

[Sedat Dilek]

On Thu, Oct 28, 2010 at 7:52 PM, Markus Trippelsdorf
<markus@xxxxxxxxxxxxxxx> wrote:
> On Thu, Oct 28, 2010 at 12:05:05PM +0200, Sedat Dilek wrote:
>> Hi,
>>
>> I have built today linux-next as of next-20101028 in a non-BKL config
>> (kernel-config attached) on a Debian i386/sid host.
>>
>> When I start my quassel IRC-client I get reproducibly this call-trace:
>>
>> # tail -40 kern.log
>> Oct 28 11:42:54 tbox kernel: [ Â 32.872957] EXT3-fs (sdb5): warning:
>> maximal mount count reached, running e2fsck is recommended
>> Oct 28 11:42:54 tbox kernel: [ Â 32.873621] EXT3-fs (sdb5): using
>> internal journal
>> Oct 28 11:42:54 tbox kernel: [ Â 32.873635] EXT3-fs (sdb5): mounted
>> filesystem with ordered data mode
>> Oct 28 11:44:16 tbox kernel: [ Â115.480401] ------------[ cut here ]------------
>> Oct 28 11:44:16 tbox kernel: [ Â115.480598] kernel BUG at
>> /home/sd/src/linux-2.6/linux-2.6.36/debian/build/source_i386_none/fs/ext4/inode.c:2721!
>
> The same BUG (inode.c:2721) happend here today running latest vanilla
> git. There is nothing in my logs unfortunately, but I shot a photo of
> the trace (see attachment).
>
> --
> Markus
>

Looks like the two patches from ext/for_linus GIT-branch stabilzes
system, here (2.6.36-git11).

root@tbox:~# uptime
 20:19:42 up 19 min,  4 users,  load average: 1.27, 0.89, 0.58

- Sedat -
From 04ee02f542b13d9e4114a2cac86b02874a658324 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@xxxxxxx>
Date: Thu, 28 Oct 2010 12:01:17 -0400
Subject: [PATCH 1/2] ext4: Fix build when !CONFIG_EXT4_FS_XATTR
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

> Theodore Ts'o (18):
>       ext4: rename {exit,init}_ext4_*() to ext4_{exit,init}_*()

Today's -tip fails to build due to upstream commit 5dabfc7 ("ext4:
rename {exit,init}_ext4_*() to ext4_{exit,init}_*()"), on
all[yes/mod]config with CONFIG_EXT4_FS_XATTR disabled:

  fs/ext4/super.c:4776: error: implicit declaration of function âext4_init_xattrâ

Commit 5dabfc7 renamed init_ext4_xattr to ext4_init_xattr but forgot
to update the definition in fs/ext4/xattr.h. The patch below fixes it.

[ Mea culpa, mea culpa, mea maximum culpa -Ted ]

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
---
 fs/ext4/xattr.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
index 281dd83..1ef1652 100644
--- a/fs/ext4/xattr.h
+++ b/fs/ext4/xattr.h
@@ -122,7 +122,7 @@ ext4_xattr_put_super(struct super_block *sb)
 }
 
 static __init inline int
-init_ext4_xattr(void)
+ext4_init_xattr(void)
 {
 	return 0;
 }
-- 
1.7.2.3

From 74ee3ef569ac76b7a600ac69097f8ff96aaa5b50 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@xxxxxxx>
Date: Thu, 28 Oct 2010 12:03:05 -0400
Subject: [PATCH 2/2] fs: build fix when !CONFIG_BLOCK
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Today's -tip fails to build on !CONFIG_BLOCK, due to upstream commit
367a51a ("fs: Add FITRIM ioctl"):

 include/linux/fs.h:36: error: expected specifier-qualifier-list before âuint64_tâ
 include/linux/fs.h:36: error: expected specifier-qualifier-list before âuint64_tâ
 include/linux/fs.h:36: error: expected specifier-qualifier-list before âuint64_tâ

The commit adds uint64_t type usage to fs.h, but linux/types.h is not
included explicitly - it's only included implicitly via
linux/blk_types.h, and there only if CONFIG_BLOCK is enabled.

Add the explicit #include to fix this.

Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
Signed-off-by: "Theodore Ts'o" <tytso@xxxxxxx>
---
 include/linux/fs.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 6ed7ace..1c73b50 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -9,6 +9,7 @@
 #include <linux/limits.h>
 #include <linux/ioctl.h>
 #include <linux/blk_types.h>
+#include <linux/types.h>
 
 /*
  * It's silly to have NR_OPEN bigger than NR_FILE, but you can change
-- 
1.7.2.3