Re: [PATCH 09/30] staging/vme: fill in struct device's .release,even if it's a NOOP

[Greg KH]

On Wed, Oct 27, 2010 at 10:46:42AM -0400, Emilio G. Cota wrote:
> On Wed, Oct 27, 2010 at 11:54:55 +0100, Martyn Welch wrote:
> > On 26/10/10 02:10, Emilio G. Cota wrote:
> > > From: Emilio G. Cota <cota@xxxxxxxxx>
> > > 
> > > Without it we get 32 warnings, one per device being released, when
> > > removing a bridge module.
> > > 
> > > After applying this patch, bridge modules can at last be removed
> > > without any apparent hiccup.
> > > 
> > > [Note: tested only on the tsi148, it's the only bridge I've got]
> > > 
> > 
> > I guess this is an artifact of the current lack of refcounting?
> 
> No, that's orthogonal to this. This has to do with the way the
> devices are allocated.
> 
> > This is definitely an issue, however I don't think masking it by adding
> > an empty function is the correct way to go.
> 
> We're not masking anything. The release method is there to free the
> struct it protects when its refcount goes to zero; however, in this
> case the struct wasn't allocated dynamically--the 32 devices are
> stored in struct vme_bridge in an array--and therefore there's
> nothing to do in .release, since struct vme_bridge is freed
> elsewhere.
> 
> While it's true that empty .release methods are usually frowned
> upon (as stated in Documentation/kobject.txt), due to the way
> things are done here it actually makes sense to have an
> empty .release.

FROWNED APON?

Heh, if you add one, as per the documentation there, I get to publicly
ridicule you for doing so.

So consider this your ridicule, if you ever are thinking you need to
create an empty release function, YOUR CODE IS WRONG!

Seriously, do you think I just add warnings in there for fun?  So that
you can work around them thinking you know better?

{sigh}

Your implementation is broken, never do this, if you create a kobject,
you HAVE TO FREE IT in the release function.

I would ask why you are even using a kobject in the first place (hint,
if you are writing a driver, or even a subsystem, you shouldn't be, use
'struct device' instead.)

So consider this a rejection of this patch and implementation :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/