Re: [PATCH] ARM: imx: Add some core definitions for MX53

[Sascha Hauer]

On Wed, Oct 27, 2010 at 07:57:11AM -0700, Nguyen Dinh-R00091 wrote:
> >
> >Yes, I know. Is MX5_1_3 better? Any other suggestions?
> 
> Not sure why we can't do something like this?
> 
> In mx5x.h, 
> MX51_PERIP_1 /* Address specific to mx51 */
> MX53_PERIP_1 /* Address specific to mx53 */
> MX5_PERIP_2 /* Address that is shared to mx51, mx53, and any later mx5X chips */

The problem is that we don't know about 'any later chips' and we don't
know whether the MX5_ assumption stays true for later MX5 chips.

To end this, let's just use the complete names for all i.MX defines,
that is MX51 for MX51 and MX53 for MX53. It's the only way to handle
this consistently for *all* i.MX, not only the MX5 ones.

Uwe has worked a lot on making the overhead for this as little s
possible and in the end we are just talking about a handfull of base
addresses and interrupt/dma request numbers. It should be simple to add
them without asking the question 'is this mxx specific or mxy also?'
over and over again.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/