Re: [PATCH] x86-32: Allocate irq stacks seperate from percpu area

From: Ingo Molnar
Date: Wed Oct 27 2010 - 11:31:14 EST



* Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Oct 26, 2010 at 10:43 PM, Brian Gerst <brgerst@xxxxxxxxx> wrote:
> > The percpu allocator cannot handle alignments larger than one page.
> > Allocate the irq stacks seperately, and only keep the pointers as
> > percpu data.
>
> Ok, so I definitely want this (although it sounds like it would be good to do the
> allocation numa-aware - possibly a separate issue).
>
> However, I also want to remove all the crap that got added for the multi-page
> percpu support. It was ugly, and apparently never really worked. All the
> PER_CPU_MULTIPAGE_ALIGNED crud just needs to go away.
>
> Ingo, can you take care of this all, or should I just take the patch and remove
> the multipage stuff manually?

Sure, i'm queuing up Brian's patch (initially wanted to wait for the NUMA-aware
version) and will remove all the multipage pcpu bits - will send you a pull request
later today, after a bit of testing.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/