Re: [PATCH 24/30] staging/vme_user: remove unnecessary call tovme_slave_set

[Emilio G. Cota]

On Wed, Oct 27, 2010 at 13:24:55 +0100, Martyn Welch wrote:
> On 26/10/10 02:11, Emilio G. Cota wrote:
> > From: Emilio G. Cota <cota@xxxxxxxxx>
> > 
> > The resource is about to be freed and therefore it is pointless to
> > set any of its parameters.
> 
> Nope - this is disabling the window, which given that you are about to
> unalloc the memory that it is using this is quite important.

Aah I didn't realise that 

> > -		vme_slave_set(image[i].resource, 0, 0, 0, 0, VME_A32, 0);

disables the window. I thought vme_slave_free would disable it as well.
Forget this one, then.

Thanks

		Emilio

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/