Re: [patch 116/176] fs: allow for more than 2^31 files

[Eric Dumazet]

Le mercredi 27 octobre 2010 Ã 13:59 +0200, Christoph Hellwig a Ãcrit :
> This patch breaks the binary sysctl ABI.  It probably doesn't matter
> as no one actually used it, but it might be better idea to just remove
> this node from the binary sysctl tree.
> 

Good point

To be precise, sysctl() truncates the value to low order 32bit value,
because it internally uses simple_strtoul(), then a put_user()

An old binary using sysctl() to fetch FS_MAXFILE could break on SGI
machines. I am not sure we should remove sysctl FS_MAXFILE because of
this rare case.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/