Re: [resend][PATCH 2/4] Revert "oom: deprecate oom_adj tunable"

From: David Rientjes
Date: Tue Oct 26 2010 - 15:38:17 EST


On Tue, 26 Oct 2010, KOSAKI Motohiro wrote:

> > NACK as a logical follow-up to my NACK for "oom: remove totalpage
> > normalization from oom_badness()"
>
> Huh?
>
> I requested you show us justification. BUT YOU DIDNT. If you have any
> usecase, show us RIGHT NOW.
>

The new tunable added in 2.6.36, /proc/pid/oom_score_adj, is necessary for
the units that the badness score now uses. We need a tunable with a much
higher resolution than the oom_adj scale from -16 to +15, and one that
scales linearly as opposed to exponentially. Since that tunable is much
more powerful than the oom_adj implementation, which never made any real
sense for defining oom killing priority for any purpose other than
polarization, the old tunable is deprecated for two years.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/