Re: [PATCH] ipmi: Run a dummy command before submitting a newcommand

[Matthew Garrett]

I've finally had time to look at this more closely. The following patch 
seems to make things happy, but I still don't have a full understanding 
of what's going on.

(Background: Some HP ilo firmware versions are unhappy due to 
3326f4f2276791561af1fd5f2020be0186459813 . Running a dummy command in 
schedule() works around this but clearly isn't the right answer. Turns 
out that this also breaks IPMI on some Suns, and Oracle reverted this in 
their kernel but never told me. Thoracle)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index e537610..763af8f 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -901,6 +901,8 @@ static void sender(void                *send_info,
 
 	mod_timer(&smi_info->si_timer, jiffies + SI_TIMEOUT_JIFFIES);
 
+	smi_info->last_timeout_jiffies = jiffies;
+
 	if (smi_info->thread)
 		wake_up_process(smi_info->thread);
 

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/