Re: [PATCH] toshiba_acpi.c: Add key_entry for a lone FN keypress

[Dmitry Torokhov]

On Tue, Oct 26, 2010 at 01:00:26PM +0100, Jon Dowland wrote:
> On Mon, Oct 25, 2010 at 11:27:35AM -0700, Dmitry Torokhov wrote:
> > Well, if FN key can generate separate events then we should report
> > KEY_FN, not KEY_UNKNOWN.
> 
> Good point, thanks.  I missed that when I went shopping for an appropriate
> KEY_*.
> 
> Adjusted patch to apply on top of current HEAD.
> 
> A lone FN key press on a Toshiba Portégé R700 without another key in
> conjunction results in an ACPI event and a spurious error message on
> the console.
> 
> Add a key entry to map this event to a KEY_UNKNOWN keypress silences

                                         ^^^^^^
Better fix commit log message as well. Otherwise:

	Acked-by: Dmitry Torokhov <dtor@xxxxxxx>

(or whatever tag Matthew might want to change it).

> this message.
> 
> Signed-off-by: Jon Dowland <jmtd@xxxxxxxxxx>
> 
> ----
> --- a/drivers/platform/x86/toshiba_acpi.c	2010-10-26 12:56:46.000000000 +0100
> +++ b/drivers/platform/x86/toshiba_acpi.c	2010-10-26 12:58:21.000000000 +0100
> @@ -135,6 +135,7 @@
>  	{ KE_KEY, 0x141, { KEY_BRIGHTNESSUP } },
>  	{ KE_KEY, 0x142, { KEY_WLAN } },
>  	{ KE_KEY, 0x143, { KEY_PROG1 } },
> +	{ KE_KEY, 0x17f, { KEY_FN } },
>  	{ KE_KEY, 0xb05, { KEY_PROG2 } },
>  	{ KE_KEY, 0xb06, { KEY_WWW } },
>  	{ KE_KEY, 0xb07, { KEY_MAIL } },

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/