Re: [PATCH] archs: add ioremap_change_write_prot

From: Andi Kleen
Date: Tue Oct 26 2010 - 09:14:31 EST


> Sorry to re-open the topic, but I'd like to receive any
> comments/feedback about this patch.

The name of the wrapper seems wrong -- this has nothing to do with IO.

I must admit I'm also not a fan of wrappers, why not call the set_memory_*
functions directly and implement them for the other archs too?

Other than that it seems reasonable.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/