Re: [PATCH 09/29] memstick: rework state machines + attribute readfunction

[Maxim Levitsky]

On Mon, 2010-10-25 at 08:23 -0700, Alex Dubov wrote:
> --- On Fri, 22/10/10, Maxim Levitsky <maximlevitsky@xxxxxxxxx> wrote:
> 
> > From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Subject: [PATCH 09/29] memstick: rework state machines + attribute read function
> > To: "Alex Dubov" <oakad@xxxxxxxxx>
> > Cc: "Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx>, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, "Maxim Levitsky" <maximlevitsky@xxxxxxxxx>
> > Received: Friday, 22 October, 2010, 4:53 PM
> > Code is rewritten to use new style of
> > state machines.
> 
> As I said before:
> 1. Rationale for this "new style".
OK, will explain in patch description better.


> 2. Human readable names for states and state transitions.
Don't want to do, I explained why.


> 3. Coding style.
passed checkpatch.pl



> 
> 
> > Attribute read function is cleaned up and commented
> > sparsely.
> > 
> 
> Belongs to separate patch. Attribute read function is quite isolated from
> everything else.
Its not.
Your old attribute read function plays games with param register,
so I will need to change it first to use global param register, and then
port it. I hate doing that. If you insist, ok.



-- 
Best regards,
        Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/